Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate breakpoint names for flex utility classes #2293

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

jamigibbs
Copy link
Contributor

@jamigibbs jamigibbs commented Sep 26, 2024

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

This PR will migrate the breakpoint names for the flex utility classes.

Current VADS Name USWDS v3 Name
xsmall-screen (320px) mobile (320px)
small-screen (480px) mobile-lg (480px)
small-desktop-screen (1008px) desktop (1024px)
large-screen (1200px) desktop-lg (1200px)

Related issue(s)

Testing done

  • confirmed locally that the new breakpoint names were applying from the CSS Library utilities stylesheet on a drupal liquid page (home page)

Screenshot 2024-09-26 at 4 53 20 PM

Screenshot 2024-09-26 at 4 52 51 PM

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have a PR with pretty much the same changes for facility pages.

@jamigibbs jamigibbs merged commit 71bf966 into main Sep 27, 2024
27 checks passed
@jamigibbs jamigibbs deleted the 3208-flex-utilities-breakpoint-name branch September 27, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants