Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS-19348: Add css style naming fix for CLPs #2296

Merged
merged 1 commit into from
Sep 27, 2024
Merged

VACMS-19348: Add css style naming fix for CLPs #2296

merged 1 commit into from
Sep 27, 2024

Conversation

chriskim2311
Copy link
Contributor

Summary

Updated image style for CLP div to show the image properly.

Related issue(s)

department-of-veterans-affairs/va.gov-cms#19348

Testing done

Screenshots

What areas of the site does it impact?

CLPs

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

@chriskim2311 chriskim2311 requested a review from a team as a code owner September 27, 2024 17:58
eselkin
eselkin approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dsasser
dsasser approved these changes Sep 27, 2024
View reviewed changes
Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG thank you for the quick fix!

@chriskim2311 chriskim2311 merged commit 82c44ca into main Sep 27, 2024
24 checks passed
@chriskim2311 chriskim2311 deleted the clp-image-hotfix branch September 27, 2024 19:42
@eselkin eselkin mentioned this pull request Sep 27, 2024
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsasser dsasser dsasser approved these changes

@eselkin eselkin eselkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chriskim2311 @dsasser @eselkin @va-vfs-bot