Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug/9615-BiometricLoginRefreshTokenFix #10040

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

Sparowhawk
Copy link
Contributor

Description of Change

Set the storage to AES for the keychain token. AES and FB according to this thread
oblador/react-native-keychain#262

Does not throw this error Wrapped error: javax.crypto.IllegalBlockSizeException which seems to be the bulk of the spike

Biometric when not specified seems to pick one based on the library settings, which I haven't been able to determine what the default is, but is likely RSA or KC which both cause this issue

Screenshots/Video

N/A

Testing

Yarn test

  • Tested on iOS
  • Tested on Android

Reviewer Validations

Biometrics should work and not kick you back out of the app and force you to log back in to use biometrics

PR Checklist

Reviewer: Confirm the items below as you review

  • PR is connected to issue(s)
  • Tests are included to cover this change (when possible)
  • No magic strings (All string unions follow the Union -> Constant type pattern)
  • No secrets or API keys are checked in
  • All imports are absolute (no relative imports)
  • New functions and Redux work have proper TSDoc annotations

For QA

Run a build for this branch

@Sparowhawk Sparowhawk requested review from a team as code owners October 25, 2024 19:21
@Sparowhawk Sparowhawk changed the title set storage to AES bug/9615-BiometricLoginRefreshTokenFix Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant