Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable and remove vagovadmin theme. #11011

Closed
2 tasks
ndouglas opened this issue Sep 30, 2022 · 3 comments · Fixed by #12985
Closed
2 tasks

Disable and remove vagovadmin theme. #11011

ndouglas opened this issue Sep 30, 2022 · 3 comments · Fixed by #12985
Assignees
Labels
CMS Team CMS Product team that manages both editor exp and devops Quality Assurance

Comments

@ndouglas
Copy link
Contributor

ndouglas commented Sep 30, 2022

Description

Right? I don't think we use it. Eh, I'll open a PR and find out.

Tasks

  • Turn it off
  • Go through config to look for custom code
  • Review PR with this turned off but not specifically removed
  • If everything looks good, we can fully remove it

Acceptance Criteria

  • The theme has been removed and we no longer have to update two copies of everything.
  • Needs design review.
@ndouglas ndouglas added Needs refining Issue status CMS Team CMS Product team that manages both editor exp and devops Quality Assurance labels Sep 30, 2022
@ndouglas ndouglas self-assigned this Sep 30, 2022
@ndouglas ndouglas removed the Needs refining Issue status label Sep 30, 2022
@timcosgrove
Copy link
Contributor

It's an active theme. What's up here?

@ndouglas
Copy link
Contributor Author

Where did you see that this is an active theme?

@ndouglas
Copy link
Contributor Author

Not sure what "active" means, actually. Locally it appears to be installed and enabled, but not default, which is AFAICT what we want right now.

My understanding is that vagovclaro was supposed to replace vagovadmin, so I opened this issue when I noticed that it was still hanging around. (Before I saw #8950) I also opened #11529 to remove it, and learned some stuff along the way, like that not everything is completely shifted from vagovadmin to vagovclaro. I think. So I think I might be closing #11529 and instead opening a series of smaller PRs to do cleanup and verifying each of those changes individually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops Quality Assurance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants