Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-11011: Disable vagovadmin theme #12945

Conversation

edmund-dunn
Copy link
Contributor

@edmund-dunn edmund-dunn commented Mar 13, 2023

Description

Relates to #11011

Testing done

Tested locally, checked /admin/structure/block for any missing, broken or duplicate blocks.

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

  1. Navigate to /admin/structure/block
    • Validate that there are no missing, borken or duplicate blocks.
  2. Then navigate to /admin/appearance
    • Validate that vagovadmin is not installed. (Note: Seven should still be installed. )

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing annoucement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn self-assigned this Mar 13, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 13, 2023 19:01 Destroyed
@edmund-dunn edmund-dunn added the CMS Team CMS Product team that manages both editor exp and devops label Mar 13, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 13, 2023 19:36 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 13, 2023 19:58 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 13, 2023 21:12 Destroyed
Copy link
Contributor

@ndouglas ndouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I clicked around a couple dozen random pages and didn't see any issues (e.g. missing or multiple blocks, broken layouts, etc). Tests pass. Good work!

@va-cms-bot va-cms-bot temporarily deployed to Tugboat March 15, 2023 14:30 Destroyed
@edmund-dunn edmund-dunn merged commit f9dc55d into department-of-veterans-affairs:main Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants