Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add existing GA events to New Homepage #12065

Closed
2 of 20 tasks
wesrowe opened this issue Dec 21, 2022 · 7 comments
Closed
2 of 20 tasks

Add existing GA events to New Homepage #12065

wesrowe opened this issue Dec 21, 2022 · 7 comments
Assignees
Labels
Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area

Comments

@wesrowe
Copy link
Contributor

wesrowe commented Dec 21, 2022

NOTE: This is a temporary fix; #11965 tracks the desired long-term fix

Description

In #11467 we added homepage-specific events to the New Home Page; however: they can't be tracked as written due to limitations in Google Tag Manager (GTM). A custom implementation is required on GTM. (Platform Analytics team has been asked to do it.)

As a temporary measure, we want to add GA events that work within the existing GTM scheme:

  1. Keep the existing custom events. (They will start working when Analytics Implementation for: EXISTING Home Page va.gov-team#50836 is resolved by the Plat Analytics team.)
  2. Write new events to temporarily track the same info using existing (aka regular) GA events, until Analytics Implementation for: EXISTING Home Page va.gov-team#50836 is resolved.

New events detailed in this Mural area
Screenshot of mural:
image

Acceptance Criteria

  • Custom events implemented previously are not altered nor removed
  • Possibly not documented elsewhere: GA event for the link in Create Account block, "Learn how an account helps you"
  • Events detailed in "AC" text of Mural above:
    • "Create Account" button has a Primary Button Click event, e.g. the "Feedback" button on the existing HP: ec: Interactions ea: Default Button CTA - [button text] - [optional: button color]
    • Search input in-page gets same GA event as header search, e.g. ec: Search ea: Search Results Returned ~ Type Ahead Enabled ~ All VA.gov ~ [search term input] el: view_search_results No-op: Turned out to be already present
    • Other search tools links get same GA as "zone one" links on existing HP (i.e., the 4 boxes): ec: Interactions ea: Navigation - Zone One - ->[optional: path of destination] - [required: link text] - [optional/not defined]
    • "Top pages" links get same GA as "zone one" links on existing HP (i.e., the 4 boxes): ec: Interactions ea: Navigation - Zone One - ->[optional: path of destination] - [required: link text] - [optional/not defined]
    • Random fix: changed "Top Pages" header text to "Top pages" (sentence case)
    • News promo ("Pathfinder...") links all tracked as "zone one"
      • Block title
      • "read full article"
      • "More VA news"
    • "Sign up" button for newsletter gets "primary button click" similar to Feedback button: ec: Interactions ea: Default Button CTA - [button text] - [optional: button color]

CMS Team

Please check the team(s) that will do this work.

  • Program
  • Platform CMS Team
  • Sitewide Crew
  • ⭐️ Sitewide CMS
  • ⭐️ Public Websites
  • ⭐️ Facilities
  • ⭐️ User support
@wesrowe wesrowe added the Needs refining Issue status label Dec 21, 2022
@github-actions github-actions bot added the Public Websites Scrum team in the Sitewide crew label Dec 21, 2022
@wesrowe wesrowe added the VA.gov frontend CMS team practice area label Dec 21, 2022
@jilladams jilladams added the Unplanned work Work that was introduced post-planning label Dec 21, 2022
@wesrowe wesrowe removed the Unplanned work Work that was introduced post-planning label Dec 21, 2022
@jilladams
Copy link
Contributor

Per Dave sync today: not soft-launch blocking for turning on the modal, but is hard-launch blocking for cutting over to the new homepage / taking down the old.

@wesrowe wesrowe changed the title Add "regular" GA events to New Homepage Add existing GA events to New Homepage Dec 30, 2022
@jtmst jtmst self-assigned this Dec 30, 2022
@jilladams
Copy link
Contributor

Search AC not valid, the rest may still be and need work. Rolling into next sprint.

@wesrowe
Copy link
Contributor Author

wesrowe commented Jan 18, 2023

@jtmst, did you get to the bottom of this? It looks above like your PR just for a search change was Closed rather than Merged 2 weeks ago. But where is the rest of your code?

@jtmst
Copy link

jtmst commented Jan 23, 2023

@wesrowe department-of-veterans-affairs/content-build#1429

Lost track of this PR around on site and it didnt actually get merged, its in now.

@jtmst jtmst closed this as completed Jan 27, 2023
@wesrowe
Copy link
Contributor Author

wesrowe commented Jan 27, 2023

@jtmst, I just tested these fixes in staging. Most ACs are validated in GA interface (a few looked good in AdSwerve but there was no data in GA; likely because no one clicked in staging).

However, one group of events was (mostly) missing from AdSwerve:

  • News promo ("Pathfinder...") links all tracked as "zone one"
    • Block title – missing any GA
    • "read full article" – missing any GA
    • "More VA news" present, but sending wrong link text; sends "read full article"

@jtmst jtmst reopened this Jan 27, 2023
@jilladams
Copy link
Contributor

PR merged, in Review/QA to verify after deploy.

@wesrowe wesrowe removed the Needs refining Issue status label Feb 9, 2023
@wesrowe
Copy link
Contributor Author

wesrowe commented Feb 11, 2023

The above were solved around 1/31, forgot to close ticket. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Public Websites Scrum team in the Sitewide crew sitewide VA.gov frontend CMS team practice area
Projects
None yet
Development

No branches or pull requests

3 participants