-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Design error and empty states for Facility Locator #15935
Comments
@xiongjaneg I had a request come in a few weeks ago on a FE ticket (#14933) to design error states for Facility Locator. I've been unable to prioritize this request, and wanted to create this ticket so it doesn't get lost. This may be a blocker for part of the work on that FE ticket. I'll need to do this one sprint ahead of that ticket getting pulled in. |
Thread re: leaving this ticket til Sprint |
@thejordanwood @aklausmeier @xiongjaneg if this issue is pulled in to support design for the mobile map iteration/testing prototype, we really only need a more elegant response for searches which do not return results for the specified service and location. But you may want to review this error state documentation in Github product folder to see what else might ne needed. (Note this was last updated in 1/2022 and likely is incomplete or outdated).
The "no results" scenario isn't actually an error state - the system is working correctly and the user has completed all fields. But the message currently displayed is quite lengthy and may not serve Veterans well, especially those using a screen reader. See the details mentioned in #13919 Revisit Facility Locator "no results" error message. We may want to consider what guidance to provide based on the list vs map view (if we're able to display a different message for each). You can experience this sort of no results scenario in a variety of ways, including
We may be able to close #13919 Revisit Facility Locator "no results" error message as a result of the work done for this one. |
@thejordanwood Renamed ticket to include empty states (no results) |
Engineering questions for future discussion
|
@laflannery Can you review this? Michelle also has a question in the comment above about how error messages work.
|
@maxx1128 @eselkin Can you review the updates to the error states I'm proposing? They can be found on the Error/Empty states page in the Facility Locator Figma file. Some questions we have in a comment above are:
If any of this in confusing (I know that Figma page has a lot of content), then I can set up a meeting for us to discuss! |
@thejordanwood reviewed and added comments to Figma |
@thejordanwood I looked at the disabled button and added my comments in Figma. Regarding the question from @mmiddaugh above, the error message should be read exactly as they are displayed visually. A screen reader will immediately hear the error once it appears and then we should make sure to handle the focus so that their next tab stop is into that incorrect field so they can easily fix their mistake. |
I'm taking info from some comments in Figma to answer these questions:
This is defined by Mapbox and we're not sure if we get that level of feedback. We may need to stick with the "For better results" message.
This is probably possible. I'm going to move forward with suggesting different error messages for when no service type is entered and when an invalid service type is entered. @maxx1128 @eselkin Feel free to add any additional information I may have missed. |
@xiongjaneg I've updated the CAIA review ticket with the suggested error/empty states messaging. We've also reviewed this in UX sync, so I believe everyone has had a chance to see this. I think next steps are CAIA review, making any additional design updates after that, then handing this off to engineering and addressing anything that comes from that. |
Description
Error states should be designed for Facility Locator to show intended behavior. According to #14993, the primary error states needed are:
Error/Empty states:
So current error states are documented on the Facility Locator error states page.
Design
Error/Empty states page in the Facility Locator Figma file
Sprint 104 Acceptance criteria
Sprint 105 Acceptance criteria
The text was updated successfully, but these errors were encountered: