Add new Services View into Vet Centers node and remove IEF

[davidmpickett]

User Story or Problem Statement

Final Drupal implementation

Description or Additional Context

• Based on design in Draft updated editorial flow for updated Vet Center services #17680: Vet Center forms Figma

Steps for Implementation

• Create the new view
• Follow design for "Add new service" button implementation, and to pass a token to Vet Center - Facility Service so the Facility is pre-populated
• Update Vet Center content type to embed this view
• Remove IEF from Vet Center
  • field_health_services should be Disabled rather than Removed, b/c it powers FE query

@davidmpickett says "Consider splitting creating the View into it's own ticket and letting this one serve as the step where you embed it in Vet Center content type and remove IEF"

@omahane said "Nope, has to go together"

Acceptance Criteria

• Editors can see the existing Facility Services for their Vet Center while editing their Vet Center
• Editors can see what services are required vs. not
• Editors can see the moderation state of a listed Vet Center facility service
• Editors can click out to a Vet Center facility service to edit
• Editors can click the "Go to services" button in their dashboard and be taken directly to the relevant part of the Vet Center node edit
• Appropriate services display on FE of Vet Center (no regression)
• SHOULD NOT MERGE until Change Management is coordinated - Change management for Vet Center IEF / allow only one changes #17840
• Requires design review
• Requires accessibility review

Close Child Tickets

Beta Give feedback

1. Revision log message on Vet Center Services are misleading #15125
   CY24-Q2 Defect Drupal engineering Facilities Vet Center sitewide +6
   
2. Last updated by human not set when Vet Center Service is saved/updated. #15124
   CY24-Q2 Defect Drupal engineering Facilities Vet Center sitewide +6
   
3. Vet Center services added through IEF bypass allow_only_one_validation #5981
   CY24-Q2 Defect Drupal engineering Facilities Needs refining Vet Center crew-sitewide sitewide +8
   

Unblock follow up FE ticket

Beta Give feedback

1. Front end: Vet Center unpublished services should not be showing on VA.gov #16362
   2 of 2
   Defect Facilities Technical debt VA.gov frontend Vet Center sitewide +6
   

[jilladams]

8 point estimate for engineering; 5 points for standing up env / testing / support & verification

[Agile6MSkinner]

#15125
#15124
#5981

Can be closed when this one is. Added a task list to track that.

[jilladams]

Change management info is updated in #17840 and target is 8/15, so this will roll into Sprint 10. @omahane best to plan some time around then for refreshing the PR to get updated to main / passing tests, etc.

[jilladams]

Updated branch on this PR and moved it to Ready to review. We can merge tomorrow after daily deploy if CI passes.

[jilladams]

Comms went out to editors for CM last night. PR is now merged. Moving to prod verify.

[jilladams]

Changes have deployed and are live in prod: https://prod.cms.va.gov/node/3784/edit

I haven't gone through full verification, so we will need some help to do UAT for end of sprint just to verify that everything's correct live, and we can close this.

[davidmpickett]

Verified the following on Clarksville Vet Center

• Services area shows up in appropriate spot on Node:Edit of Vet Center
• Service names are linked to Node:View of correct Services
• Edit buttons open Node:Edit of correct Service
• Add service button correctly pre-populates Vet Center and Section fields on Node:Create for Service
• All links open in new tab

[davidmpickett]

Verified on Vet Center dashboard for Clarksville

• Clicking the Go to Services button directly jumps the user top the Services part of the correct Vet Center

[davidmpickett]

Verified on Staging for Clarksville Vet Center

• Adding an Optional service shows up correctly as optional on Service list
• Required Services cannot be Archived
• Optional Services can be archived

[davidmpickett]

One small regression, the Jump to edit link at the top broke because the id for the Services area changes from
#edit-field-health-services to #edit-group-vet-center-services

I know that we talked about spinning up a dedicated ticket for addressing all the Anchor Links on the Vet Center content types after @laflannery's feedback on the Mission explainer ticket. I am comfortable having that fix be part of that ticket.

[davidmpickett]

And here's that ticket: #18953

[davidmpickett]

Closing as complete and verified