-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VACMS-18723 Exported and added configs to git for Mission Explainer #18890
VACMS-18723 Exported and added configs to git for Mission Explainer #18890
Conversation
GitHub Workflows (.github/workflows/*.yml)Have you...
|
@davidmpickett @laflannery Could you take a look at this before I look at the code/config: https://pr18890-tt9t9v1nunrmm5opymrkq5ncspqnmuxa.ci.cms.va.gov/admin/content |
Looking good! @jv-agile6 Some comments
|
Can we add an anchor link on the Vet Center edit screen under "Jump to edit" for this section? I'm not sure how difficult this is but these are all out of whack so if we start to fix them little by little it would help. |
🤔 Is this a green 🟢 to merge? 🚂 It's got all the right approval, 🥇 right? @omahane @davidmpickett . Anything further should be on a new ticket, right? 🙏 |
@jv-agile6 I don't see any ✅ official approvals on the PR. While @omahane is out, you may need @dsasser to step in to review and approve. |
@laflannery I think it would be better since Jerry is spinning several plates / this PR has been in motion for awhile if you're willing to ticket so we can come back to fixing these holistically. |
@laflannery I'm not sure why would we do that, as this is not content that an editor can edit. |
d2ea80c
to
938d5ff
Compare
@davidmpickett (cc: @jilladams @jv-agile6 The PR Env has been updated to match the suggested changes: Node:viewNode:edit |
@jv-agile6 the QA steps here are hard to follow from a numbering standpoint, and the steps lack links. Can you take a pass at updating the steps to be easier to follow for someone not familiar with this work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and QA steps passed nice work ✅
Approved @dsasser |
Description
Added a Mission Explainer content block to the Vet center content type.
Relates to #18723
Testing done
Screenshots
Centralized Content
Vet Center Content Type
QA steps
As a drupal admin:
Validate that a centralized content descriptor content block was added to VetCenter Centralized Content
Update Nodes by performing a bulk edit to the centralized content
Go to the bulk edit page filtered by vet center content type
Select all results
Choose modify field values, and apply
Choose Mission Explainer field
Apply and confirm
Then check a Vet Center node for Mission Explainer on node view.
Select Team for PR review
CMS Team
Public websites
Facilities
User support
Accelerated Publishing