Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-18723 Exported and added configs to git for Mission Explainer #18890

Merged
merged 4 commits into from
Aug 15, 2024

Conversation

jv-agile6
Copy link
Contributor

@jv-agile6 jv-agile6 commented Aug 8, 2024

Description

Added a Mission Explainer content block to the Vet center content type.
Relates to #18723

Testing done

Screenshots

Centralized Content

Screenshot 2024-08-07 at 9 14 15 AM Screenshot 2024-08-09 at 9 08 15 AM

Vet Center Content Type

Screenshot 2024-08-09 at 12 49 24 PM

QA steps

As a drupal admin:

Validate that a centralized content descriptor content block was added to VetCenter Centralized Content

"Our services
We offer these confidential services at our Vet Centers:

Counseling and a range of other services for individuals, families, and group sessions
Alternative therapies and events may be offered such as art, equine, yoga, or fly fishing
Connections to more support in VA and your community
Note: You may be eligible for these services no matter your discharge status or eligibility for VA health care. And we won’t share anything about you or the services you receive at a Vet Center without your permission."

  • Content block shows on node:edit and node:view(if low LOE) on VetCenter Content Type

Update Nodes by performing a bulk edit to the centralized content

  • Go to the bulk edit page filtered by vet center content type

  • Select all results

  • Choose modify field values, and apply

  • Choose Mission Explainer field

  • Apply and confirm

  • Then check a Vet Center node for Mission Explainer on node view.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 8, 2024 19:25 Destroyed
@jv-agile6 jv-agile6 requested a review from omahane August 9, 2024 14:10
@jv-agile6 jv-agile6 marked this pull request as ready for review August 9, 2024 14:35
@jv-agile6 jv-agile6 requested a review from a team as a code owner August 9, 2024 14:35
@github-actions github-actions bot added the Facilities Facilities products (VAMC, Vet Center, etc) label Aug 9, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 9, 2024 16:13 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 9, 2024 17:47 Destroyed
Copy link

github-actions bot commented Aug 9, 2024

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@omahane
Copy link
Contributor

omahane commented Aug 9, 2024

@davidmpickett @laflannery Could you take a look at this before I look at the code/config: https://pr18890-tt9t9v1nunrmm5opymrkq5ncspqnmuxa.ci.cms.va.gov/admin/content

@davidmpickett
Copy link
Contributor

davidmpickett commented Aug 9, 2024

Looking good! @jv-agile6 Some comments

  1. Centralized content - Please drag the two paragraphs for Mission Explainer to be above Vet Center non-traditional hours. Our general principle is that elements in the Drupal UI should be in the same order as the items will appear on the corresponding FE page to help reduce cognitive load for editors.
  2. Centralized content descriptor copy suggestions:
    Title: Vet Center services overview
    Body: This content appears in a blue box at the top of Vet Center pages.
  3. EFF box on vet center nodes - Position should probably be under Top of page information rather than above it (same principle as in item 1 above)
  4. EFF box on Vet center nodes - change label from Mission explainer to "Vet Center services overview"
  5. EFF box on Vet center nodes - probably needs a tool tip with the standard "why can't I edit this?" text

@laflannery
Copy link
Contributor

Can we add an anchor link on the Vet Center edit screen under "Jump to edit" for this section? I'm not sure how difficult this is but these are all out of whack so if we start to fix them little by little it would help.

@jv-agile6
Copy link
Contributor Author

jv-agile6 commented Aug 12, 2024

🤔 Is this a green 🟢 to merge? 🚂 It's got all the right approval, 🥇 right? @omahane @davidmpickett . Anything further should be on a new ticket, right? 🙏

@davidmpickett
Copy link
Contributor

@jv-agile6 I don't see any ✅ official approvals on the PR. While @omahane is out, you may need @dsasser to step in to review and approve.

@jilladams
Copy link
Contributor

@laflannery I think it would be better since Jerry is spinning several plates / this PR has been in motion for awhile if you're willing to ticket so we can come back to fixing these holistically.

@omahane
Copy link
Contributor

omahane commented Aug 15, 2024

Can we add an anchor link on the Vet Center edit screen under "Jump to edit" for this section? I'm not sure how difficult this is but these are all out of whack so if we start to fix them little by little it would help.

@laflannery I'm not sure why would we do that, as this is not content that an editor can edit.

@omahane
Copy link
Contributor

omahane commented Aug 15, 2024

@davidmpickett (cc: @jilladams @jv-agile6
The prod centralized content has been updated:
https://prod.cms.va.gov/centralized-content/national-vet-center-content

The PR Env has been updated to match the suggested changes:

Node:view

Screenshot 2024-08-15 at 12 28 16 AM

Node:edit

Screenshot 2024-08-15 at 12 29 15 AM

@omahane omahane requested a review from dsasser August 15, 2024 04:46
@dsasser
Copy link
Contributor

dsasser commented Aug 15, 2024

@jv-agile6 the QA steps here are hard to follow from a numbering standpoint, and the steps lack links. Can you take a pass at updating the steps to be easier to follow for someone not familiar with this work?

Copy link
Contributor

@dsasser dsasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good and QA steps passed nice work ✅

@jv-agile6
Copy link
Contributor Author

Approved @dsasser

@jv-agile6 jv-agile6 merged commit 3e81667 into main Aug 15, 2024
20 checks passed
@jv-agile6 jv-agile6 deleted the VACMS-18723AddMissionExplainerContentBlockToVetCenter branch August 15, 2024 19:26
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 27, 2024 23:35 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants