Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin/content moderation state filter is repeating itself and broken #6342

Closed
4 of 7 tasks
swirtSJW opened this issue Sep 3, 2021 · 1 comment · Fixed by #6343
Closed
4 of 7 tasks

Admin/content moderation state filter is repeating itself and broken #6342

swirtSJW opened this issue Sep 3, 2021 · 1 comment · Fixed by #6343
Labels
crew-sitewide Critical defect Typically set as "high priority" in zenhub. Platform CMS Team

Comments

@swirtSJW
Copy link
Contributor

swirtSJW commented Sep 3, 2021 •
edited
Loading

UPDATE: THis is impacting all moderation state filters on all Views.
Describe the defect
To Reproduce

  1. Go to /admin/content.
  2. Pull down the "moderation state" filter
  3. Notice each of the entries is repeated, along with weird text about who can archive.
  4. ALso notice that none of the selections (other than "any"return any results). gife defferrent results if you pick the first or the second set of choices.

image

Selections are giving odd results too.
image

Expected behavior
Each moderation state should only appear once.
When a filter is selected,

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information if relevant, or delete):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Add any other context about the problem here. Reach out to the Product Managers to determine if it should be escalated as critical (prevents users from accomplishing their work with no known workaround and needs to be addressed within 2 business days).

Labels

(You can delete this section once it's complete)

  • Issue type (red) (defaults to "Defect")
  • CMS subsystem (green)
  • CMS practice area (blue)
  • CMS objective (orange) (not needed for bug tickets)
  • CMS-supported product (black)

CMS Team

Please leave only the team that will do this work selected. If you're not sure, it's fine to leave both selected.

  • Core Application Team
  • Product Support Team
@swirtSJW swirtSJW added the Defect Something isn't working (issue type) label Sep 3, 2021
@swirtSJW swirtSJW changed the title Admin/content moderrations state filter is repeating itself. Admin/content moderation state filter is repeating itself and broken Sep 3, 2021
@swirtSJW swirtSJW added Critical defect Typically set as "high priority" in zenhub. and removed Defect Something isn't working (issue type) labels Sep 3, 2021
swirtSJW added a commit to swirtSJW/va.gov-cms that referenced this issue Sep 3, 2021
@swirtSJW
Revert "VACMS-5248: Prevent archiving of certain content types by non…
7459130 
…-content-admins. (department-of-veterans-affairs#5249)"

This reverts commit a8795b3.

This was necessary to resolve department-of-veterans-affairs#6342
@swirtSJW swirtSJW mentioned this issue Sep 3, 2021
Merged
12 tasks
@kevwalsh kevwalsh mentioned this issue Sep 7, 2021
Closed
19 tasks
swirtSJW added a commit to swirtSJW/va.gov-cms that referenced this issue Sep 7, 2021
@swirtSJW
Revert "VACMS-5248: Prevent archiving of certain content types by non…
3b9a633 
…-content-admins. (department-of-veterans-affairs#5249)"

This reverts commit a8795b3.

This was necessary to resolve department-of-veterans-affairs#6342
swirtSJW added a commit that referenced this issue Sep 7, 2021
@swirtSJW
VACMS-6342 Revert VACMS-5248 (#6343)
7298e60 
* Revert "VACMS-5248: Prevent archiving of certain content types by non-content-admins. (#5249)"

This reverts commit a8795b3.

This was necessary to resolve #6342

* VACMS-5249 Convert content_admin workflows to editorial workflows.
@cmaeng
Copy link
Contributor

cmaeng commented Nov 29, 2021

Slack thread here: https://dsva.slack.com/archives/CT4GZBM8F/p1630704530283500

Probably not a critical defect as it only affected content findability but we addressed within 2 business days regardless.

@cweagans cweagans mentioned this issue Feb 7, 2022
Closed
23 tasks
@davidmpickett davidmpickett mentioned this issue May 17, 2023
Closed
@swirtSJW swirtSJW mentioned this issue Aug 3, 2023
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crew-sitewide Critical defect Typically set as "high priority" in zenhub. Platform CMS Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

VACMS-6342 Revert VACMS-5248 swirtSJW/va.gov-cms
2 participants
@swirtSJW @cmaeng