Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VACMS-10870: Upgrade to PHP 8.1 #11833

Merged
merged 23 commits into from
Dec 8, 2022
Merged

VACMS-10870: Upgrade to PHP 8.1 #11833

merged 23 commits into from
Dec 8, 2022

Conversation

timcosgrove
Copy link
Contributor

@timcosgrove timcosgrove commented Dec 6, 2022 •
edited
Loading

Description

Support for PHP 8.1 upgrade.

@timcosgrove timcosgrove added the DO NOT MERGE Do not merge this PR label Dec 6, 2022
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2022 23:25 Destroyed
@timcosgrove timcosgrove marked this pull request as ready for review December 6, 2022 23:25
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2022 23:25 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 6, 2022 23:45 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2022 00:09 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2022 00:48 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2022 00:59 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2022 02:30 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2022 02:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2022 03:01 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2022 04:38 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2022 10:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2022 14:28 Destroyed
ndouglas
ndouglas reviewed Dec 7, 2022
View reviewed changes
.tugboat/config.yml
Comment on lines +4 to +5
# Use PHP 8.1 with Apache; this syntax pulls in the latest version of PHP 8.1.
# Currently, using Buster because of an issue with Bullseye and PHP 8.1 on Tugboat.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this comment still accurate?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Use PHP 8.1 with Apache; this syntax pulls in the latest version of PHP 8.1.
# Currently, using Buster because of an issue with Bullseye and PHP 8.1 on Tugboat.
# Use PHP 8.1 with Apache; this syntax pulls in the latest version of PHP 8.1.
# Currently, using Buster because of an issue with Bullseye and PHP 8.1 on Tugboat.
# The issue is because Docker is to old, and we need to update Docker on Tugboat.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not commit this, but rip this comment out in #11884.

phpunit.xml.bak
@@ -0,0 +1,79 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Contributor

@ndouglas ndouglas Dec 7, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file editor cruft?

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 7, 2022 16:43 Destroyed
@ElijahLynn
Copy link
Contributor

Sweet, all these checks/tests passed.
image

I am testing on test.staging now.

@ElijahLynn ElijahLynn changed the title DNM: Vacms 10870 upgrade to php81 rebased DNM: VACMS-10870: Upgrade to PHP 8.1 Dec 8, 2022
@ElijahLynn
Copy link
Contributor

W00t! Tests on test.staging with latest commit cb1aec3 have PASSED ✔️!

@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 8, 2022 10:27 Destroyed
@ElijahLynn ElijahLynn mentioned this pull request Dec 8, 2022
Closed
4 tasks
@ElijahLynn ElijahLynn changed the title DNM: VACMS-10870: Upgrade to PHP 8.1 VACMS-10870: Upgrade to PHP 8.1 Dec 8, 2022
@ElijahLynn
Copy link
Contributor

We need to fix composer.lock conflict then we are good to merge this, I just merged https://github.com/department-of-veterans-affairs/devops/pull/12251 which needed to be merged before this.

Edmund Dunn and others added 19 commits December 8, 2022 10:17
VACMS-10870: str_replace deprecation fix
31ce289
@ElijahLynn @dependabot @timcosgrove
VACMS-10870: Upgrade Tugboat and Composer from PHP 7.4 to 8.1. (#11200)
3aa584a 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tim Cosgrove <timcosgrove@users.noreply.github.com>
VACMS-10870: updates to fix deprecations
6c72961
VACMS-10870: do nto display notices for behat testing
e6c8af6
VACMS-10870: update composer lock
9f7a959
@ElijahLynn
temp: optimize_autoloader: false
e1b66d9 
To get around an issue with 'invalid opcode'
@ElijahLynn
VACMS-11315: Tugboat & DDEV: opcache.jit = disable (#11417)
3514b9e
VACMS-10870: fix for behat I hope
80454d3
VACMS-10870: more attempts to fic behat deprecated notice reporting
64182d5
@edmund-dunn
VACMS-10780: update composer.lock (#11441)
bf8938e 
* VACMS-10780: update composer.lock

* VACMS-10870: another composer.lock update

* VACMS-10870: fix for tugboat and drush

* VACMS-10870: more deprecation fixes

* VACMS-10870: added php81 patch for health_check_url module

* VACMS-10870: fixed deprecations
@ElijahLynn
'(int) ini_get(..)'
3a714cf
Update phpunit.
3c85798
Adding phpspec/prophecy-phpunit.
42b110a
Updated phpunit schema with --migrate-configuration.
bb825c8
Making FeatureFlag class compatible with the trait it implements.
673b8d7
Additional small updates.
283bc46
Bringing FeatureFlag implementation in line with interface.
46f50f6
@ndouglas
VACMS-0000: Use ProphecyTrait for PHPUnit tests. (#11844)
8ef4ad1
Ensuring valid composer.lock.
fac6381
@timcosgrove timcosgrove force-pushed the VACMS-10870-upgrade-to-php81_rebased branch from cb1aec3 to fac6381 Compare December 8, 2022 18:24
@va-cms-bot va-cms-bot temporarily deployed to Tugboat December 8, 2022 18:24 Destroyed
@ElijahLynn
Copy link
Contributor

We discussed on Slack here to not run tests again because it was a composer lock conflict, so we are merging this.

https://dsva.slack.com/archives/C02HX4AQZ33/p1670523995148309?thread_ts=1670522273.320169&cid=C02HX4AQZ33

Once this is merged we need to "rebuild" (not refresh) all the Tugboat base PRs and have engineers update their local DDEV envs.

@ElijahLynn ElijahLynn removed the DO NOT MERGE Do not merge this PR label Dec 8, 2022
@ElijahLynn ElijahLynn merged commit 8f0e656 into main Dec 8, 2022
@ElijahLynn ElijahLynn deleted the VACMS-10870-upgrade-to-php81_rebased branch December 8, 2022 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndouglas ndouglas ndouglas left review comments

@ElijahLynn ElijahLynn ElijahLynn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@timcosgrove @ElijahLynn @ndouglas @va-cms-bot @edmund-dunn