Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNM] VACMS-14529 Add Views filter for multiple workflows. #14784

Conversation

swirtSJW
Copy link
Contributor

Description

Relates to #14529

Testing done

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 15, 2023 15:07 Destroyed
@swirtSJW swirtSJW changed the title VACMS-14529 Add Views filter for multiple workflows. [DNM] VACMS-14529 Add Views filter for multiple workflows. Aug 15, 2023
@swirtSJW swirtSJW self-assigned this Aug 15, 2023
@swirtSJW swirtSJW added the Facilities Facilities products (VAMC, Vet Center, etc) label Aug 15, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 16, 2023 03:35 Destroyed
@swirtSJW swirtSJW force-pushed the VACMS-14529-add-views-filter-for-multiple-workflows branch from 76bbe98 to 46473e9 Compare August 21, 2023 03:48
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 21, 2023 03:48 Destroyed
@swirtSJW swirtSJW added the DO NOT MERGE Do not merge this PR label Aug 21, 2023
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 24, 2023 19:11 Destroyed
@swirtSJW swirtSJW force-pushed the VACMS-14529-add-views-filter-for-multiple-workflows branch from 8c3acb7 to c3b25e8 Compare August 24, 2023 19:13
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 24, 2023 19:14 Destroyed
@github-actions
Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 29, 2023 20:10 Destroyed
@swirtSJW swirtSJW force-pushed the VACMS-14529-add-views-filter-for-multiple-workflows branch from c3b25e8 to a35c18e Compare September 5, 2023 14:49
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 5, 2023 14:49 Destroyed
@swirtSJW swirtSJW force-pushed the VACMS-14529-add-views-filter-for-multiple-workflows branch from a35c18e to f4abc95 Compare September 5, 2023 14:53
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 5, 2023 14:53 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 5, 2023 15:04 Destroyed
@swirtSJW swirtSJW force-pushed the VACMS-14529-add-views-filter-for-multiple-workflows branch from f4abc95 to fc487ac Compare September 5, 2023 15:11
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 5, 2023 15:11 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 5, 2023 16:43 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 6, 2023 13:38 Destroyed
@jilladams
Copy link
Contributor

Removed sprints.

@swirtSJW
Copy link
Contributor Author

swirtSJW commented Nov 3, 2023

I am closing this as it was just the POC to prove we could do it, and the real thing has already made it to prod.

@swirtSJW swirtSJW closed this Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge this PR Facilities Facilities products (VAMC, Vet Center, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants