Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-16851: cms next gh worfklow comms #17991

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

alexfinnarn
Copy link
Contributor

Description

Relates to #16851 as a WIP PR...

Testing done

...

Screenshots

Screenshot 2024-04-22 at 1 48 27 PM

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

As user uid with user_role

  1. Do this
    • Validate that
  2. Then
    • Validate that
  3. Then validate Acceptance Criteria from issue
    • a
    • b
    • c

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@va-cms-bot va-cms-bot temporarily deployed to Tugboat April 29, 2024 19:51 Destroyed
@github-actions github-actions bot changed the title Vacms 16851 cms next gh worfklow comms VACMS-16851: cms next gh worfklow comms Apr 29, 2024
Copy link

GitHub Workflows (.github/workflows/*.yml)

Have you...

  • pinned all affected GitHub Actions at a specific commit by SHA?
  • reviewed the source code of the action at the commit you are pinning?
  • confirmed that no GitHub security measures are being bypassed?
  • checked for any injection of user content into protected contexts?
  • reviewed Security hardening for GitHub Actions?
  • reviewed GitHub Workflows?

@alexfinnarn alexfinnarn linked an issue Apr 29, 2024 that may be closed by this pull request
@va-cms-bot va-cms-bot temporarily deployed to Tugboat May 21, 2024 21:10 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat June 4, 2024 18:39 Destroyed
@va-cms-bot
Copy link
Collaborator

va/tests/status-error:


entity_update
Title Entity/field definitions
Severity Error
Sid 2
Description The following changes were detected in the entity type and field definitions.
.... Content

         * The /node.field_datetime_range_timezone/ field needs to be updated.        
                                                                                      
        .... Paragraph                                                                
                                                                                      
         * The /paragraph.field_datetime_range_timezone/ field needs to be updated.   

Value Mismatched entity and/or field definitions

@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 1, 2024 16:26 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 1, 2024 19:14 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 1, 2024 21:12 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 1, 2024 21:24 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 23, 2024 18:56 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat July 29, 2024 16:54 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat August 27, 2024 23:33 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 9, 2024 15:56 Destroyed
],
]);
}
catch (Exception $exception) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[PHPStan] reported by reviewdog 🐶
Caught class Drupal\va_gov_content_release\Form\Exception not found.

*/
public function buildForm(
array $form,
FormStateInterface $form_state
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [PHP_CodeSniffer] <Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma> reported by reviewdog 🐶
Multi-line function declarations must have a trailing comma after the last parameter

*/
public function submitForm(
array &$form,
FormStateInterface $form_state
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [PHP_CodeSniffer] <Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma> reported by reviewdog 🐶
Multi-line function declarations must have a trailing comma after the last parameter

@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 13, 2024 20:02 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 18, 2024 08:27 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 19, 2024 08:29 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 20, 2024 08:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 21, 2024 08:25 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 22, 2024 08:24 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 23, 2024 08:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 24, 2024 08:35 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 25, 2024 08:25 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 26, 2024 08:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 27, 2024 08:27 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 28, 2024 08:28 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 29, 2024 08:26 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat September 30, 2024 08:25 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 1, 2024 08:21 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 2, 2024 08:23 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 3, 2024 08:27 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replicate CMS & Next Build communication on CMS side
3 participants