Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAMCS-19329: filter unexpected log messages containing pii #19388

Merged

Conversation

edmund-dunn
Copy link
Contributor

Description

Closes #19329
Closes #19345

Testing done

Tested on cms-test, test.staging. Reviewed results with Tyler Bird.

Screenshots

QA steps

What needs to be checked to prove this works?
What needs to be checked to prove it didn't break any related things?
What variations of circumstances (users, actions, values) need to be checked?

This can't be tested on tugboat because we don't send tugboat logs to datadog.

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.
  • If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

  • CMS Team
  • Public websites
  • Facilities
  • User support
  • Accelerated Publishing

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping the UX writer so they are ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping the UX writer to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@edmund-dunn edmund-dunn requested review from a team as code owners October 2, 2024 17:42
@edmund-dunn edmund-dunn linked an issue Oct 2, 2024 that may be closed by this pull request
2 tasks
@edmund-dunn edmund-dunn self-assigned this Oct 2, 2024
@va-cms-bot va-cms-bot temporarily deployed to Tugboat October 2, 2024 17:43 Destroyed
@edmund-dunn edmund-dunn enabled auto-merge (squash) October 2, 2024 18:06
@github-actions github-actions bot added the CMS Team CMS Product team that manages both editor exp and devops label Oct 2, 2024
@edmund-dunn edmund-dunn merged commit 07e91bb into main Oct 2, 2024
18 checks passed
@edmund-dunn edmund-dunn deleted the 19329-filter-unexpected-log-messages-containing-pii branch October 2, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMS Team CMS Product team that manages both editor exp and devops
Projects
None yet
3 participants