-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP [tugboat] Initial pass at placing a proxy that redirects to named URL #4399
WIP [tugboat] Initial pass at placing a proxy that redirects to named URL #4399
Conversation
…s based on Tugboat Preview name
… now that there is a proxy in front.
This is working functionally! Clicking either of these links redirects to the preview-name with the correct cms or web prefix now.
I think there might be an issue with tests still because of the redirect though. |
8ddb6a4
to
f66cf1f
Compare
I just ran these test cases in Chrome for DEMO and CI:
|
Same results on Firefox. So it appears that the maximum hostname label length is 64 characters. The spec says 63 bytes so not sure where but I am off by one here. The Tugboat TOKEN length is currently 33 CHARS, which leaves us 30 CHARS, minus the 4 CHAR prefix of I think this is good to merge after I fix the conflicts and put a "why" comment on the trim length. |
Conflicts: .tugboat/config.yml
3324843
to
f7fee25
Compare
…ing' warning" This reverts commit ce634f3. IDE likes this commit but `sh` does not: '/bin/sh: 2: Syntax error: "|" unexpected'
Given a Preview name of:
The resulting URL is https://cms-pr4399-james-tugboat-ali-feojue32sjv0ltus10z7byw7iz13zxa5.ci.cms.va.gov/. Given:
URL:
|
Closing for now as we can't implement this just yet as the URLs for 60+ demo environments will change. Will re-open if/when time comes. |
This PR adds experimental support for human readable aliases that display in the URL bar when they are clicked from within the Tugboat UI.