Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VAGOV-5857: Adding all flags to config. #561

Merged
merged 1 commit into from
Sep 4, 2019

Conversation

ethanteague
Copy link
Contributor

Adding config to mirror prod version of flags.

Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks Ethan.

@swirtSJW swirtSJW merged commit 7359f6b into develop Sep 4, 2019
@ElijahLynn
Copy link
Contributor

ElijahLynn commented Sep 4, 2019

Let's keep the below in mind for when we override these flags since config overrides don't show in the UI and is very confusing in Drupal 8.

https://www.drupal.org/project/config_override_warn (Dave Reid Module) (see https://www.drupal.org/project/drupal/issues/2408549 for context)

@ElijahLynn ElijahLynn deleted the VAGOV-5857-flags-config-et branch September 4, 2019 21:42
ElijahLynn pushed a commit that referenced this pull request Sep 5, 2019
* VAGOV-5834: Remove inline entity form widgets. (#560)

* VAGOV-5857: Adding all flags to config. (#561)

* VAGOV-000: Empty commit for devops test to trigger CD to DEV.

* VAGOV-5827 Use PROD SSO metadata and endpoint.

* VAGOV-5827 Remove SSOi simplesaml_php module enable from staging.

This effectively removes enabling from all environments, but keeps the
config if we do enable it manually. We are enabling manually on PROD for
a dark deployment as we need to confirm with IAM team that it is working
and they can wrap up their work.

We have some follow up work to do to get existing accounts linked to new
SSOi federated logins so we don't duplicate accounts.

* VAGOV-000: Empty commit for devops test to trigger CD to DEV. #2

* VAGOV-5827 Enable SSO on PROD.
swirtSJW pushed a commit that referenced this pull request Sep 6, 2019
* VAGOV-5834: Remove inline entity form widgets. (#560)

* VAGOV-5857: Adding all flags to config. (#561)

* VAGOV-000: Empty commit for devops test to trigger CD to DEV.

* VAGOV-5827 Use PROD SSO metadata and endpoint.

* VAGOV-5827 Remove SSOi simplesaml_php module enable from staging.

This effectively removes enabling from all environments, but keeps the
config if we do enable it manually. We are enabling manually on PROD for
a dark deployment as we need to confirm with IAM team that it is working
and they can wrap up their work.

We have some follow up work to do to get existing accounts linked to new
SSOi federated logins so we don't duplicate accounts.

* VAGOV-000: Empty commit for devops test to trigger CD to DEV. #2

* VAGOV-5827 Enable SSO on PROD.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants