Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS-7582: Updates Tugboat, Lando, and DDEV to use PHP 7.4. #7684

Conversation

ndouglas
Copy link
Contributor

Description

Closes #7582.

I've tested Lando, DDEV, and Tugboat separately with PHP 7.4, but not with the contents of this specific PR. I'll do some more of that this afternoon.

Testing done

Screenshots

QA steps

As user uid with user_role

  1. Do this
  2. Then that
  3. Then validate Acceptance Criteria from issue
  • This
  • That
  • The other thing

Definition of Done

  • Documentation has been updated, if applicable.
  • Tests have been added if necessary.
  • Automated tests have passed.
  • Code Quality Tests have passed.
  • Acceptance Criteria in related issue are met.
  • Manual Code Review Approved.

Select Team for PR review

  • Platform CMS team
  • Sitewide CMS Team
    • ⭐️ Content ops
    • ⭐️ CMS Experience
    • ⭐️ Offices
    • ⭐️ Product Support

Is this PR blocked by another PR?

  • DO NOT MERGE

Does this PR need review from a Product Owner

  • Needs PO review

CMS user-facing annoucement

Is an announcement needed to let editors know of this change?

  • Yes, and it's written in issue ____ and queued for publication.
    • Merge and ping @ rachel-kauff so she's ready to publish after deployment
  • Yes, but it hasn't yet been written
    • Don't merge yet -- ping @ rachel-kauff to prompt her to write and queue content
  • No announcement is needed for this code change.
    • Merge & carry on unburdened by announcements

@ndouglas ndouglas self-assigned this Jan 20, 2022
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 20, 2022 17:16 Destroyed
@va-cms-bot va-cms-bot temporarily deployed to Tugboat January 27, 2022 12:32 Destroyed
@ndouglas
Copy link
Contributor Author

ndouglas commented Jan 27, 2022

@indytechcook Thoughts about merging this, considering that the actual upgrade for BRD to PHP 7.4 will be delayed?

@ndouglas ndouglas removed the DO NOT MERGE Do not merge this PR label Jan 27, 2022
@ndouglas ndouglas changed the title VACMS-7582: Updates Tugboat, Lando, and DDEV to use PHP 7.4. [DO NOT MERGE] VACMS-7582: Updates Tugboat, Lando, and DDEV to use PHP 7.4. Jan 27, 2022
@indytechcook
Copy link
Contributor

@indytechcook Thoughts about merging this, considering that the actual upgrade for BRD to PHP 7.4 will be delayed?

I like the idea of php7.4 running locally for a bit before putting it on BRD.

@ndouglas ndouglas merged commit 770aae6 into department-of-veterans-affairs:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Code validation of upgrade to PHP 7.4
3 participants