Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VAGOV-6374: Adding draggable table functionality. #902

Merged
merged 7 commits into from
Feb 6, 2020
Merged

VAGOV-6374: Adding draggable table functionality. #902

merged 7 commits into from
Feb 6, 2020

Conversation

ethanteague
Copy link
Contributor

What this does

  • Allows for table drag sorting on node forms

QA

  • Go to /node/589/edit
  • In Main Content section, open up a table field.
  • Change sort order
  • Save, confirm new order has been preserved.

Screenshots

image

swirtSJW
swirtSJW approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@swirtSJW swirtSJW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@swirtSJW
Copy link
Contributor

swirtSJW commented Feb 6, 2020

Tests passed locally for me. Moving this along with CI being down.

@swirtSJW swirtSJW merged commit 975c392 into department-of-veterans-affairs:master Feb 6, 2020
@rachel-kauff rachel-kauff added the CMS announcement Many epics need a release notes issue. label Feb 25, 2020
@kevwalsh kevwalsh mentioned this pull request Feb 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swirtSJW swirtSJW swirtSJW approved these changes

Assignees
No one assigned
Labels
CMS announcement Many epics need a release notes issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ethanteague @swirtSJW @va-cms-bot @rachel-kauff