Skip to content

Commit

Permalink
updates from comments
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris Kim authored and Chris Kim committed Sep 6, 2024
1 parent 6b0184e commit 492e6c6
Show file tree
Hide file tree
Showing 2 changed files with 33 additions and 8 deletions.
32 changes: 27 additions & 5 deletions src/applications/discharge-wizard/constants/display-conditions.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { range } from 'lodash';
import { months } from 'platform/static-data/options-for-select';
import { RESPONSES } from './question-data-map';

const get15YearsPast = () => `${new Date().getFullYear() - 15}`;
Expand All @@ -12,9 +13,19 @@ const yearResponses = range(currentYear - 1992).map(i => {
yearResponses.push('Before 1992');

const validYearsForNonOldDischarge = yearResponses.filter(year => {
return currentYear - year <= 15;
return currentYear - year < 15;
});

const determineMonths = months.reduce((newArray, month) => {
const currentMonth = new Date().getMonth() + 1;
if (currentMonth <= month.value) {
newArray.push(month.value.toString());
}
return newArray;
}, []);

const year15Yearsago = (new Date().getFullYear() - 15).toString();

const {
ARMY,
NAVY,
Expand Down Expand Up @@ -171,10 +182,21 @@ export const DISPLAY_CONDITIONS = Object.freeze({
},
},
FAILURE_TO_EXHAUST: {
DISCHARGE_YEAR: [...validYearsForNonOldDischarge],
COURT_MARTIAL: [COURT_MARTIAL_NO, NOT_SURE],
INTENTION: [INTENTION_NO],
PREV_APPLICATION_TYPE: [PREV_APPLICATION_BCMR, PREV_APPLICATION_BCNR],
FORK: {
0: {
DISCHARGE_YEAR: [...validYearsForNonOldDischarge],
COURT_MARTIAL: [COURT_MARTIAL_NO, NOT_SURE],
INTENTION: [INTENTION_NO],
PREV_APPLICATION_TYPE: [PREV_APPLICATION_BCMR, PREV_APPLICATION_BCNR],
},
1: {
DISCHARGE_YEAR: [year15Yearsago],
DISCHARGE_MONTH: [...determineMonths],
COURT_MARTIAL: [COURT_MARTIAL_NO, NOT_SURE],
INTENTION: [INTENTION_NO],
PREV_APPLICATION_TYPE: [PREV_APPLICATION_BCMR, PREV_APPLICATION_BCNR],
},
},
},
PRIOR_SERVICE: {
FORK: {
Expand Down
9 changes: 6 additions & 3 deletions src/applications/discharge-wizard/constants/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ export const questionsToClearMap = Object.freeze({
SHORT_NAME_MAP.DISCHARGE_MONTH,
SHORT_NAME_MAP.FAILURE_TO_EXHAUST,
],
DISCHARGE_MONTH: [],
DISCHARGE_MONTH: [SHORT_NAME_MAP.FAILURE_TO_EXHAUST],
REASON: [
SHORT_NAME_MAP.DISCHARGE_TYPE,
SHORT_NAME_MAP.COURT_MARTIAL,
Expand All @@ -172,8 +172,8 @@ export const questionsToClearMap = Object.freeze({
SHORT_NAME_MAP.PRIOR_SERVICE,
SHORT_NAME_MAP.FAILURE_TO_EXHAUST,
],
DISCHARGE_TYPE: [],
COURT_MARTIAL: [],
DISCHARGE_TYPE: [SHORT_NAME_MAP.PRIOR_SERVICE],
COURT_MARTIAL: [SHORT_NAME_MAP.FAILURE_TO_EXHAUST],
INTENTION: [],
PREV_APPLICATION: [
SHORT_NAME_MAP.PREV_APPLICATION_TYPE,
Expand All @@ -196,7 +196,10 @@ export const questionsToClearMap = Object.freeze({

export const forkableQuestions = [
SHORT_NAME_MAP.DISCHARGE_YEAR,
SHORT_NAME_MAP.DISCHARGE_MONTH,
SHORT_NAME_MAP.REASON,
SHORT_NAME_MAP.COURT_MARTIAL,
SHORT_NAME_MAP.DISCHARGE_TYPE,
SHORT_NAME_MAP.PREV_APPLICATION,
SHORT_NAME_MAP.PREV_APPLICATION_TYPE,
SHORT_NAME_MAP.PREV_APPLICATION_YEAR,
Expand Down

0 comments on commit 492e6c6

Please sign in to comment.