Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schemaform dl.review mobile enchantments #31665

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

josephrlee
Copy link
Contributor

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to Summary and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Summary

  • Made dl.review more responsive
  • Made dt and dd stack on mobile
  • Removed max/min width values so that content isn't unnecessarily small on the left dt
  • Used column-gap

Related issue(s)

Testing done

  • Tested locally

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile Screenshot 2024-08-28 at 3 48 01 PM Screenshot 2024-08-28 at 3 31 09 PM
Tablet Screenshot 2024-08-28 at 3 48 06 PM Screenshot 2024-08-28 at 3 31 15 PM
Desktop Screenshot 2024-08-28 at 3 48 13 PM Screenshot 2024-08-28 at 3 31 31 PM

What areas of the site does it impact?

Affects the review page for all forms

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

- Made dl.review more responsive
- Made dt and dd stack on mobile
- Removed max/min width values so that content isn't unnecessarily small on the left dt
- Used column-gap
@josephrlee josephrlee requested review from a team as code owners August 28, 2024 22:51
@josephrlee
Copy link
Contributor Author

@micahchiang, here's the PR, let me know if you need any more documentation. Thanks!

@josephrlee josephrlee merged commit 4859559 into main Aug 29, 2024
85 checks passed
@josephrlee josephrlee deleted the schemaform-dr-review-page-refinement branch August 29, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants