-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dependents 71248 | Step 3: Remove dependents who have died (Form 686) #31896
Draft
Midge-dev
wants to merge
20
commits into
main
Choose a base branch
from
dependents-71248-remove-deceased
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
September 11, 2024 21:59
Inactive
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
September 13, 2024 19:27
Inactive
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
September 16, 2024 20:52
Inactive
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
September 16, 2024 22:29
Inactive
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
September 18, 2024 18:09
Inactive
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
September 19, 2024 21:06
Inactive
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
September 20, 2024 19:17
Inactive
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
September 23, 2024 18:51
Inactive
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
September 24, 2024 20:02
Inactive
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
September 30, 2024 20:55
Inactive
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
October 1, 2024 22:02
Inactive
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
October 1, 2024 22:40
Inactive
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
October 2, 2024 17:53
Inactive
Midge-dev
added
the
dependents-benefits
Label used for Pull Requests that impact Add/Remove Dependents claims (686c/674)
label
Oct 2, 2024
Midge-dev
changed the title
Init
Dependents 71248 | Step 3: Remove deponents who have died (Form 686)
Oct 2, 2024
Midge-dev
commented
Oct 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generateTransition helper added for other active devs
Midge-dev
commented
Oct 2, 2024
@@ -103,7 +103,7 @@ export { | |||
export function customTransformForSubmit(formConfig, form) { | |||
const payload = cloneDeep(form); | |||
// manually delete view:confirmEmail, since in our case we actually want the other view fields | |||
delete payload.data.veteranContactInformation['view:confirmEmail']; | |||
// delete payload.data.veteranContactInformation['view:confirmEmail']; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Temp removing until submission rework
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
October 2, 2024 18:31
Inactive
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
October 2, 2024 18:40
Inactive
Midge-dev
changed the title
Dependents 71248 | Step 3: Remove deponents who have died (Form 686)
Dependents 71248 | Step 3: Remove dependents who have died (Form 686)
Oct 2, 2024
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
October 2, 2024 22:03
Inactive
DLarson-Oddball
approved these changes
Oct 2, 2024
micahaspyr
approved these changes
Oct 3, 2024
va-vfs-bot
temporarily deployed
to
master/dependents-71248-remove-deceased/main
October 3, 2024 17:15
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependents-benefits
Label used for Pull Requests that impact Add/Remove Dependents claims (686c/674)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.
Are you removing, renaming or moving a folder in this PR?
If the folder you changed contains a
manifest.json
, search for itsentryName
in the content-build registry.json (theentryName
there will match).If an entry for this folder exists in content-build and you are:
Deleting a folder:
vets-website
for all instances of theentryName
in yourmanifest.json
and remove them in a separate PR. Look particularly for references insrc/applications/static-pages/static-pages-entry.js
andsrc/platform/forms/constants.js
. If you do not do this, other applications will break!Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).
Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the
#sitewide-public-websites
Slack channel for questions.Did you change site-wide styles, platform utilities or other infrastructure?
Summary
Related issue(s)
Testing done
What areas of the site does it impact?
/view-change-dependents/add-remove-form-21-686c-v2/
All of this work is behind the flipper
va_dependents_v2
and will be incrementally rolled outFigma
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
#sitewide-public-websites
Slack channel for questionsRequested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?