Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 19339 - vads-u only replace for screensize breakpoints #32128

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Sep 26, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • Replace old screen size breakpoints with USWDS names
  • Sitewide team (only changed Sitewide Facilities owned apps)

Related issue(s)

Testing done

  • Manual testing

Screenshots

Old screen size breakpoints stopped working

What areas of the site does it impact?

Facility applications

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@eselkin eselkin marked this pull request as ready for review September 27, 2024 17:42
@eselkin eselkin requested review from a team as code owners September 27, 2024 17:42
Copy link
Contributor

@chriskim2311 chriskim2311 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eselkin eselkin merged commit d2e7586 into main Sep 27, 2024
86 checks passed
@eselkin eselkin deleted the VACMS-19339-screen-size-breakpoint-names branch September 27, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants