Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MHV-53461 reworked hide alert #32166

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Conversation

KolbyVA
Copy link
Contributor

@KolbyVA KolbyVA commented Sep 30, 2024

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

If the folder you changed contains a manifest.json, search for its entryName in the content-build registry.json (the entryName there will match).

If an entry for this folder exists in content-build and you are:

  1. Deleting a folder:

    1. First search vets-website for all instances of the entryName in your manifest.json and remove them in a separate PR. Look particularly for references in src/applications/static-pages/static-pages-entry.js and src/platform/forms/constants.js. If you do not do this, other applications will break!
      • Add the link to your merged vets-website PR here
    2. Then, Delete the application entry in registry.json and merge that PR before this one
      • Add the link to your merged content-build PR here
  2. Renaming or moving a folder: Update the entry in the registry.json, but do not merge it until your vets-website changes here are merged. The content-build PR must be merged immediately after your vets-website change is merged in to avoid CI errors with content-build (and Tugboat).

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

Part 2 of this PR: #32050

Addressing comments/concerns from PR that was merged early due to business ask.

Related issue(s)

https://jira.devops.va.gov/browse/MHV-53461

Add error message for attachments that failed virus scan by the API (Start a new message page)

Note: This does not apply to a multiple draft scenario. (0.1% of session on va.gov run into multiple drafts)

Attachments will be scanned for viruses by the backend. The front end will need to let the user know that the attachment did not pass the scanning process and will not be attached to the message.

Testing done

To test, download txt test file from https://www.eicar.org/download-anti-malware-testfile/#top. This appears to the api as a virus, but is NOT an actual virus. Attach it to a message and send it. The api should throw an error and the alert should appear. This may not work with the other test file types (such as pdf), but should work with the txt file.

Adding additional unit tests

Screenshots

image

What areas of the site does it impact?

secure-messaging

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-53461-virus-alert-pt-2/main September 30, 2024 17:12 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/MHV-53461-virus-alert-pt-2/main September 30, 2024 17:53 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants