GI folder: Updating breakpoint prefixes w/ new names #32243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micahchiang
requested changes
Oct 3, 2024
| @@ -18,7 +18,7 @@ const SchoolCategoryRating = ({ titleObj, questionsObj }) => { | |||
| }; | |||
|
|
|||
| return ( | |||
| <div className="medium-screen:vads-l-col--6 small-screen:vads-l-col--12 xsmall-screen:vads-l-col--12"> | |||
| <div className="medium-screen:vads-l-col--6 mobile-lg:vads-l-col--12 mobile:vads-l-col--12"> | |||
There was a problem hiding this comment.
Hey @GovCIOLiz - It wasn't clear in my original announcement about breakpoint names and utilities, for that I apologize. The grid classes here, vads-l-col--12 and vads-l-col--6, are not actually utility classes and have not been converted to the new breakpoint names yet. Could you please revert these to small-screen and xsmall-screen? They should still work as intended because they're still getting imported from formation through core.scss.
There was a problem hiding this comment.
I'll drop a message in vfs-frontend to communicate this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Are you removing, renaming or moving a folder in this PR?
Summary
Updating, testing, reviewing updated utility class breakpoint prefixes in gi/
Related issue(s)
Platform CSS utility class migration
Testing done
Local responsive testing
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
GI - comparison tool
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?