Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sorting and address mobile styles #32247

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

iseabock-va
Copy link
Contributor

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

This PR address mobile styles, the Filter and Sort CTA for mobile, and sort ordering for all benefits mobile and desktop

Related issue(s)

  • Link to ticket created in va.gov-team repo
    department-of-veterans-affairs/va.gov-team#0000
  • Link to previous change of the code/bug (if applicable)
    department-of-veterans-affairs/vets-website#0000
  • Link to epic if not included in ticket
    department-of-veterans-affairs/va.gov-team#0000

Testing done

Manual and unit

Screenshots

Screen Shot 2024-10-02 at 2 02 24 PM

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@iseabock-va iseabock-va requested a review from a team as a code owner October 3, 2024 14:24
Copy link
Contributor

@vetskrieg vetskrieg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I already refactored this page to use VaSelect component because it creates a proper on the page instead of a plain . Please review the import and make sure this is using the correct web component.

@va-vfs-bot va-vfs-bot temporarily deployed to master/fix-sort-address-mobile-styling/main October 3, 2024 14:49 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/fix-sort-address-mobile-styling/main October 3, 2024 16:18 Inactive
@iseabock-va iseabock-va force-pushed the fix-sort-address-mobile-styling branch from fe12d73 to 3cd8b15 Compare October 3, 2024 18:15
@va-vfs-bot va-vfs-bot temporarily deployed to master/fix-sort-address-mobile-styling/main October 3, 2024 18:43 Inactive
Copy link
Contributor

@vetskrieg vetskrieg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something has changed to cause code coverage to drop below 80%. Please run:
yarn test:coverage-app benefit-eligibility-questionnaire

@va-vfs-bot va-vfs-bot temporarily deployed to master/fix-sort-address-mobile-styling/main October 4, 2024 01:17 Inactive
@iseabock-va iseabock-va force-pushed the fix-sort-address-mobile-styling branch from d0aa129 to a0fc2e9 Compare October 4, 2024 15:10
@va-vfs-bot va-vfs-bot temporarily deployed to master/fix-sort-address-mobile-styling/main October 4, 2024 15:19 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/fix-sort-address-mobile-styling/main October 4, 2024 17:09 Inactive
@iseabock-va iseabock-va force-pushed the fix-sort-address-mobile-styling branch from 2638f3c to 1362c44 Compare October 4, 2024 18:23
@va-vfs-bot va-vfs-bot temporarily deployed to master/fix-sort-address-mobile-styling/main October 4, 2024 18:36 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants