-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Sorting and address mobile styles #32247
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I already refactored this page to use VaSelect component because it creates a proper on the page instead of a plain . Please review the import and make sure this is using the correct web component.
fe12d73
to
3cd8b15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something has changed to cause code coverage to drop below 80%. Please run:
yarn test:coverage-app benefit-eligibility-questionnaire
d0aa129
to
a0fc2e9
Compare
2638f3c
to
1362c44
Compare
Are you removing, renaming or moving a folder in this PR?
Did you change site-wide styles, platform utilities or other infrastructure?
Summary
This PR address mobile styles, the Filter and Sort CTA for mobile, and sort ordering for all benefits mobile and desktop
Related issue(s)
department-of-veterans-affairs/va.gov-team#0000
department-of-veterans-affairs/vets-website#0000
department-of-veterans-affairs/va.gov-team#0000
Testing done
Manual and unit
Screenshots
Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).
What areas of the site does it impact?
(Describe what parts of the site are impacted if code touched other areas)
Acceptance criteria
Quality Assurance & Testing
Error Handling
Authentication
Requested Feedback
(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?