Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VA-IIR 1041] WIP initial contact list loop setup #32249

Merged

Conversation

john-rodriguez-adhocteam
Copy link
Contributor

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

⚠️ TeamSites ⚠️

Examples of a TeamSite: https://va.gov/health and https://benefits.va.gov/benefits/. This scenario is also referred to as the "injected" header and footer. You can reach out in the #sitewide-public-websites Slack channel for questions.

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

  • This form will not be released to production yet (see the companion content-build PR below).
  • Work for the VA-IIR team, which is creating a new review information form for the Welcome VA Setup process
  • The ticket for the work is found here.
  • We are setting up the initial contact info list loop so that we can make edits and changes requested by UX in subsequent tickets.
  • The companion content-build PR to add this form to the registry.json—but not yet to prod—is found here.

Related issue(s)

Testing done

  • Standard tests required by the generator are included.

What areas of the site does it impact?

  • This is a new form app that does not affect other apps.

Acceptance criteria

  • Match the initial configuration of the contact info list loop form

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@va-vfs-bot va-vfs-bot temporarily deployed to master/personalization/1041-default-contact-list-loop/main October 3, 2024 15:23 Inactive
@john-rodriguez-adhocteam john-rodriguez-adhocteam marked this pull request as ready for review October 3, 2024 16:01
@va-vfs-bot va-vfs-bot temporarily deployed to master/personalization/1041-default-contact-list-loop/main October 3, 2024 16:09 Inactive
@nicksayre
Copy link
Contributor

LGTM!

To run the site, first start the mock api:

yarn mock-api --responses src/applications/personalization/dashboard/mocks/server.js

Then in another console, build and run:

yarn build:webpack:local --env api="http://localhost:3000"
WEB_PORT=3001 node src/platform/testing/e2e/test-server.js --buildtype=localhost

Then visit: http://localhost:3001/my-va/welcome-va-setup/review-information/contact-information

@john-rodriguez-adhocteam john-rodriguez-adhocteam merged commit 03b98d9 into main Oct 4, 2024
77 of 79 checks passed
@john-rodriguez-adhocteam john-rodriguez-adhocteam deleted the personalization/1041-default-contact-list-loop branch October 4, 2024 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants