Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Why might I have this debt additional info component #32269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JunTaoLuo
Copy link
Contributor

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to TeamSites and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Did you change site-wide styles, platform utilities or other infrastructure?

Summary

Remove unused Why might I have this debt additional info components

Related issue(s)

Testing done

  • This PR does not introduce new behaviors and only removes dead code so ensuring existing tests pass is sufficient

Screenshots

N/A

What areas of the site does it impact?

  • Combined Debts Portal
  • Financial Status Report

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

@JunTaoLuo JunTaoLuo requested review from a team as code owners October 4, 2024 15:48
@@ -10,210 +7,3 @@ export const deductionCodes = Object.freeze({
'74': 'Post-9/11 GI Bill debt for tuition',
'75': 'Post-9/11 GI Bill debt for tuition (school liable)',
});

export const renderAdditionalInfo = deductionCode => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops I just realized that this team generally split CDP and FSR changes into separate PRs. I did find that both renderAdditionalInfo and renderWhyMightIHaveThisDebt are unused in FSR so I removed them as well but let me know if I should revert this or do it in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants