Merge pull request #8165 from dependabot/nishnha/fix-docker-versions-2

Remove the leading v from Docker versions
dependabot · Oct 10, 2023 · 1b3368e · 1b3368e
2 parents 07d1e84 + 82ffce2
commit 1b3368e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/docker/lib/dependabot/docker/file_parser.rb b/docker/lib/dependabot/docker/file_parser.rb
@@ -50,7 +50,7 @@ def parse
 
             dependency_set << Dependency.new(
               name: parsed_from_line.fetch("image"),
-              version: version,
+              version: version.sub(/^v/, ""),
               package_manager: "docker",
               requirements: [
                 requirement: nil,
@@ -127,7 +127,7 @@ def workfile_file_dependencies(file)
       def build_image_dependency(file, details, version)
         Dependency.new(
           name: details.fetch("image"),
-          version: version,
+          version: version.sub(/^v/, ""),
           package_manager: "docker",
           requirements: [
             requirement: nil,

diff --git a/docker/spec/dependabot/docker/file_parser_spec.rb b/docker/spec/dependabot/docker/file_parser_spec.rb
@@ -1115,7 +1115,7 @@
         it "has the right details" do
           expect(dependency).to be_a(Dependabot::Dependency)
           expect(dependency.name).to eq("sql/sql")
-          expect(dependency.version).to eq("v1.2.3")
+          expect(dependency.version).to eq("1.2.3")
           expect(dependency.requirements).to eq(expected_requirements)
         end
       end