Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo lib with name 'examples` incorrectly classified as binary #1156

Closed
prasannavl opened this issue May 17, 2019 · 3 comments
Closed

Cargo lib with name 'examples` incorrectly classified as binary #1156

prasannavl opened this issue May 17, 2019 · 3 comments
Labels
L: rust:cargo Rust crates via cargo T: bug 🐞 Something isn't working

Comments

@prasannavl
Copy link

Hi there! We've started using dependabot for Rust Async Working Group. However with one of our project restructure in our http server, tide, our experience was brought to halt very quickly hitting a bug that caused dependabot to fail our repo:

https://github.com/rustasync/tide/

Context

Issue here: http-rs/tide#225

It appears dependabot currently validates Cargo manifest by adding dummy code to both lib.rs and main.rs for every crate. This behaviour is different from how cargo handles it, and we ended up hitting into a case where we have examples crate, but it doesn't have a binary (which is disallowed by cargo).

Source of the bug: version_resolver.rb L310-L325

Would be super cool if you could take a look at this soon! Thanks! :)

@greysteil
Copy link
Contributor

Oh, interesting. Thanks for this feedback.

That's definitely a bug in Dependabot. Any recommendations on how we fix it? As you can probably tell, our current approach for fooling Cargo into thinking we have some code is pretty crude (but effective)...!

@stale
Copy link

stale bot commented Oct 23, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within seven days. Thank you for your contributions.

@stale stale bot added the wontfix label Oct 23, 2019
@rebelagentm rebelagentm added T: bug 🐞 Something isn't working and removed wontfix labels Oct 23, 2019
@rebelagentm rebelagentm added the L: rust:cargo Rust crates via cargo label Oct 30, 2019
@stale
Copy link

stale bot commented Dec 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs within seven days. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: rust:cargo Rust crates via cargo T: bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants