Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize examples and make runnable #227

Closed
wants to merge 1 commit into from

Conversation

prasannavl
Copy link
Contributor

Description

Make examples runnable with:
cargo run -p examples --bin <example_name> (or)
cargo run --bin <example_name> (from examples dir)

Resolves #223

(Wait until to avoid conflicts: #220)

Motivation and Context

#219 (review)
#219 (comment)

How Has This Been Tested?

All examples functional

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Refactor

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@yoshuawuyts
Copy link
Member

Related issue #225 -- our new examples structure broke our dependency automation. We should probably find a way to fix that.

@prasannavl
Copy link
Contributor Author

Waiting this one out until #220 - then choose from one of #225.

fix main fn for multipart, and fn visibility for others

change data path in multipart example
@prasannavl
Copy link
Contributor Author

Rebased and merge-able. However still doesn't resolve #225. Is it an option to wait a few days to see dependabot/dependabot-core#1156 is fixed, and if not rename it to example?

@yoshuawuyts
Copy link
Member

It looks like this requires another rebase also.

@yoshuawuyts
Copy link
Member

Commented in #223 (comment).

@prasannavl
Copy link
Contributor Author

Closing, as #247 resolves this nicely.

@prasannavl prasannavl closed this May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split examples into binaries that are runnable independently
2 participants