Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make Job parse all Hashes into class instances immediately #9561

Open
jakecoffman opened this issue Apr 22, 2024 · 0 comments
Open

make Job parse all Hashes into class instances immediately #9561

jakecoffman opened this issue Apr 22, 2024 · 0 comments

Comments

@jakecoffman
Copy link
Member

jakecoffman commented Apr 22, 2024

Code improvement description

To prevent an issue like #9560 from happening again, we should have the job pass around class instances instead of hashes.

This will also eliminate the risk of typos.

Here's a few to get started, but there's probably more:

  • ignore_conditions
  • existing_pull_requests
  • existing_group_pull_requests
@jakecoffman jakecoffman changed the title make Job class parse ignore_conditions into class instances immediately make Job parse all Hashes into class instances immediately Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Scoping
Development

No branches or pull requests

1 participant