Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type existing prs in the job definition #10432

Merged
merged 5 commits into from
Aug 14, 2024
Merged

type existing prs in the job definition #10432

merged 5 commits into from
Aug 14, 2024

Conversation

jakecoffman
Copy link
Member

@jakecoffman jakecoffman commented Aug 14, 2024

What are you trying to accomplish?

Replaces an Array of Hashes with an actual class! This prevents typos and makes Sorbet more useful.

Anything you want to highlight for special attention from reviewers?

One challenge here was we use a mini-version of Dependency. So I didn't want to reuse the Dependency class as the comparison is kind of special, so I made an inner-class Dependency under Pull Request. Is that confusing? Should it have a different name?

How will you know you've accomplished your goal?

This change should have no functional difference, so as long as the type checking and tests are passing, and no new errors popup after deployment we should be good.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@jakecoffman
Copy link
Member Author

jakecoffman commented Aug 14, 2024

I think I may have just fixed a bug with 3079ac2. When checking to see if we already created a PR we should also consider PRs created by this very job.

The NuGet smoke tests used to be

created | AspNetCore.HealthChecks.Rabbitmq ( from 5.0.2 to 7.0.0 ), Microsoft.Extensions.Diagnostics.HealthChecks ( from 5.0.17... |
created | Microsoft.Extensions.Diagnostics.HealthChecks ( from 5.0.17 to 7.0.9 )                                                   |

but now it skips the second PR because it was already bumped in the first PR.

@jakecoffman jakecoffman marked this pull request as ready for review August 14, 2024 14:09
@jakecoffman jakecoffman requested a review from a team as a code owner August 14, 2024 14:09
Copy link
Member

@abdulapopoola abdulapopoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping us to make the code better!

@jakecoffman jakecoffman merged commit 3ce1165 into main Aug 14, 2024
143 of 146 checks passed
@jakecoffman jakecoffman deleted the type-existing-prs branch August 14, 2024 16:01
@JamieMagee JamieMagee added the sorbet 🍦 Relates to Sorbet types label Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sorbet 🍦 Relates to Sorbet types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants