type existing prs in the job definition #10432
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Replaces an Array of Hashes with an actual class! This prevents typos and makes Sorbet more useful.
Anything you want to highlight for special attention from reviewers?
One challenge here was we use a mini-version of Dependency. So I didn't want to reuse the Dependency class as the comparison is kind of special, so I made an inner-class Dependency under Pull Request. Is that confusing? Should it have a different name?
How will you know you've accomplished your goal?
This change should have no functional difference, so as long as the type checking and tests are passing, and no new errors popup after deployment we should be good.
Checklist