use unique directory for temp nuget packages #10243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
force-pushed
the
dev/brettfo/nuget-test-package-dir
branch
from
ec13581
to
6849322
Compare
abdulapopoola
approved these changes
Jul 18, 2024
JoeRobich
reviewed
Jul 18, 2024
| @@ -37,12 +37,23 @@ public NuGetContext(string? currentDirectory = null, ILogger? logger = null) | |||
| .Where(p => p.IsEnabled) | |||
| .ToImmutableArray(); | |||
| Logger = logger ?? NullLogger.Instance; | |||
| TempPackageDirectory = Path.Combine(Path.GetTempPath(), ".dependabot", "packages"); | |||
| TempPackageDirectory = Path.Combine(Path.GetTempPath(), $"dependabot-packages_{Guid.NewGuid():d}"); | |||
There was a problem hiding this comment.
Since most of the other files generated during a run are under {temp}/.dependabot, why move these out?
There was a problem hiding this comment.
I was seeing cases of flaky tests. With the re-used directory and a lot of test packages being named "Some.Package/1.0.0" there could be some overlap if a previous test left a package in this directory that didn't match what the next test exepcted (e.g., different target framework, etc.), especially with the lazy downloading behavior.
There was a problem hiding this comment.
☝️ might indicate a code comment would be useful to say "here's why we're doing this"
JoeRobich
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some CI runs fail due to a corrupted temporary NuGet package. I can't get this to fail locally, but it seems to have a~30% failure rate in CI. The temp directory is re-used between tests and I'm exploring a theory that one test writes a corrupt package and the next test reads that. This PR uses a unique directory each time. I'll be running CI repeatedly to see if I can get it to fail.
I've run the NuGet leg of the CI 10 times with no failures. I'm good to call this ready.