Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use main smoke-tests repo again #10253

Merged

Conversation

deivid-rodriguez
Copy link
Contributor

@deivid-rodriguez deivid-rodriguez commented Jul 19, 2024

What are you trying to accomplish?

Use the official smoke-tests repo, not my fork.

Anything you want to highlight for special attention from reviewers?

Needs dependabot/smoke-tests#216 to be merged first for CI to get green.

How will you know you've accomplished your goal?

CI gets green and no mention of deivid-rodriguez's repo in dependabot's workflows.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@deivid-rodriguez
Copy link
Contributor Author

Oh, actually since now we autodetect which tests to run, CI is green. But in order for the new smoke tests to actually be run, dependabot/smoke-tests#216 needs to be merged.

@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review July 19, 2024 16:10
@deivid-rodriguez deivid-rodriguez requested a review from a team as a code owner July 19, 2024 16:10
@jeffwidman jeffwidman merged commit f0a0dce into dependabot:main Jul 22, 2024
106 checks passed
@jeffwidman
Copy link
Member

I merged w/o deploying as this is a test-infra-only change.

@deivid-rodriguez deivid-rodriguez deleted the deivid-rodriguez/reconcile branch July 22, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants