Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ArgumentError Malformed version number string in github actions #10314

Merged
merged 1 commit into from
Jul 31, 2024

Conversation

amazimbe
Copy link
Contributor

@amazimbe amazimbe commented Jul 30, 2024

What are you trying to accomplish?

Fix issue: https://github.com/github/dependabot-updates/issues/6446

More than 7.6k occurrences of this issue in Sentry and a large proportion of these are in the github actions ecosystem.

https://github.com/github/dependabot-updates/issues/6446

How will you know you've accomplished your goal?

I expect no more occurrences of this issue, with an empty string version, in github actions

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@amazimbe amazimbe requested a review from a team as a code owner July 30, 2024 10:32
@github-actions github-actions bot added the L: github:actions GitHub Actions label Jul 30, 2024
Copy link
Contributor

@thavaahariharangit thavaahariharangit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jurre jurre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain what the scenario is that causes this error to happen and what the result for the end user is right now, and what it will be after this change?

@amazimbe amazimbe force-pushed the amazimbe/fix-github-actions-malformed-version branch from cd6fdea to db8f0d5 Compare July 31, 2024 08:07
@amazimbe amazimbe merged commit 8296fc2 into main Jul 31, 2024
54 checks passed
@amazimbe amazimbe deleted the amazimbe/fix-github-actions-malformed-version branch July 31, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
L: github:actions GitHub Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants