add directory to existing PR checks, updating tests #10325
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
Similar to #10320, we need to update the tests to add directory for existing-pull-requests data to ensure we're testing what's being used in production from now on.
This revealed a few errors and some missed coverage.
Anything you want to highlight for special attention from reviewers?
Unlike #10320, the files involved here are not using DependencyChange, and are not multi-dir aware. So they use
job.source.directory
since there can only be one directory involved.How will you know you've accomplished your goal?
The silent e2e tests here are reliable so I don't feel the need to reproduce this behavior in a repo.
Checklist