Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add directory to existing PR checks, updating tests #10325

Merged
merged 11 commits into from
Aug 2, 2024

Conversation

jakecoffman
Copy link
Member

@jakecoffman jakecoffman commented Jul 31, 2024

What are you trying to accomplish?

Similar to #10320, we need to update the tests to add directory for existing-pull-requests data to ensure we're testing what's being used in production from now on.

This revealed a few errors and some missed coverage.

Anything you want to highlight for special attention from reviewers?

Unlike #10320, the files involved here are not using DependencyChange, and are not multi-dir aware. So they use job.source.directory since there can only be one directory involved.

How will you know you've accomplished your goal?

The silent e2e tests here are reliable so I don't feel the need to reproduce this behavior in a repo.

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@jakecoffman jakecoffman marked this pull request as ready for review July 31, 2024 13:52
@jakecoffman jakecoffman requested a review from a team as a code owner July 31, 2024 13:52
@jakecoffman jakecoffman merged commit b4882cb into main Aug 2, 2024
122 checks passed
@jakecoffman jakecoffman deleted the add-directory-to-existing-checks branch August 2, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants