Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Dependabot::SharedHelpers::HelperSubprocessFailed issues #10349

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Aug 2, 2024

What are you trying to accomplish?

Preface: Fixes issues related with Dependabot::SharedHelpers::HelperSubprocessFailed

Issues and fixes: Following are the exceptions and intended fixes:

  1. Issue related with socket hang up . It was observed that a variation of socket hang up exception was returned from native helper which was not handled.

request to https://nexus.xyz.com/repository/npm-js/ejs failed,reason: socket hang up

Fix: modifies the exception filter to contain the exception

  1. Issues related with ESOCKETTIMEDOUT. Following response was returned from native helper on socket time out.
    https://npm.pkg.github.com/@group%2ffe-release: ESOCKETTIMEDOUT

    Fix: Adds exception filter and raises PrivateSourceTimedOut exception.

  2. If package.json file is malformed, premature close response is returned from native helper.

    Fix: Handles and raises and exception DependencyFileNotParseable

  3. Object for dependency is empty response is returned from native helper in case of package-lock.json content has issues.

    Fix: Response is handled via DependencyFileNotResolvable exception and a valid message is passed to user.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Aug 2, 2024
@sachin-sandhu sachin-sandhu marked this pull request as ready for review August 2, 2024 14:00
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner August 2, 2024 14:00
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/dependabot-npm-yarn-updatechecker-latestversionfinder-registryerror branch from cc4dbcd to 2c54fae Compare August 2, 2024 15:35
@sachin-sandhu sachin-sandhu merged commit 86a880e into main Aug 2, 2024
65 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/dependabot-npm-yarn-updatechecker-latestversionfinder-registryerror branch August 2, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants