convert test to not require the network #10355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettfo
commented
Aug 2, 2024
| { | ||
| "catalogEntry": { | ||
| "id": "Delisted.Package", | ||
| "listed": false, |
There was a problem hiding this comment.
This line is what requires this to be a network test; there's no way to fake this with a local packge feed.
brettfo
force-pushed
the
dev/brettfo/nuget-test-no-network
branch
2 times, most recently
from
ec09760
to
363dfd5
Compare
brettfo
force-pushed
the
dev/brettfo/nuget-test-no-network
branch
from
363dfd5
to
825fbb0
Compare
JamieMagee
approved these changes
Aug 2, 2024
JamieMagee
reviewed
Aug 2, 2024
| @@ -0,0 +1,23 @@ | |||
| namespace NuGetUpdater.Core.Test; | |||
|
|
|||
| public class TemporaryEnvironment : IDisposable | |||
There was a problem hiding this comment.
This is such a useful pattern! I can't believe I've never seen it before.
abdulapopoola
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When #9694 was created to force unit tests to not hit the network, there was one case where we didn't yet have the test infrastructure, because one particular test requires network access, but now we have the appropriate test helpers to hit
localhost. This PR simply converts this remaining test from using real packages from nuget.org to using test-only packages and alocalhostNuGet feed.I've manually confirmed that we hit the same codepath.