NPM: fix security update for indirect and direct dependencies #10371
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you trying to accomplish?
When a security update is run and the project has the vulnerability as both a direct dependency, and indirect dependency of other top-level dependencies, Dependabot only fixes the top-level dependency.
By using the audit's abilities during the
lowest_security_fix_version
check we can returnnil
to force a full unlock.Also made a slight modification to return audit results more often when doing a security update.
Anything you want to highlight for special attention from reviewers?
How will you know you've accomplished your goal?
I have a real-world test here: https://github.com/dsp-testing/npm-multiple-top-level-ancestors
The PR created should remove all instances of the vulnerable lodash.
Checklist