Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Dependabot::ToolVersionNotSupported issues #10390

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Aug 7, 2024

What are you trying to accomplish?

Preface: Fixes issues related with Dependabot::ToolVersionNotSupported error in codebase

Issue: Issue related to exception handling Dependabot::ToolVersionNotSupported which was propagating to unknown_errors due to error handler missing from errors.rb .

Fix: Added error handler to errors.rb and handled unsanitary message.

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu marked this pull request as ready for review August 7, 2024 22:59
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner August 7, 2024 22:59
@sachin-sandhu sachin-sandhu self-assigned this Aug 7, 2024
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/dependabot-toolversionnotsupported branch 2 times, most recently from 7db6285 to 515bdc7 Compare August 10, 2024 19:20
@sachin-sandhu sachin-sandhu force-pushed the ssandhu/dependabot-toolversionnotsupported branch from 515bdc7 to d2fb896 Compare August 12, 2024 18:06
@sachin-sandhu sachin-sandhu merged commit 4bbcea3 into main Aug 12, 2024
122 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/dependabot-toolversionnotsupported branch August 12, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants