Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes illformed requirement error propagation to unknown errors #10448

Merged
merged 2 commits into from
Aug 15, 2024

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Aug 15, 2024

What are you trying to accomplish?

Preface: Issue related with Gem::Requirement::BadRequirementError exception propagation to unknown errors

Issue: BadRequirementError is raised if manifest file contains illformed requirement specs.

"lodash":"preview~1.2"

Fix: Add exception handler to stop propagation to unknown errors

+------------------------------------------------------------+
|               Dependencies failed to update                |
+------------------------------------+-----------------------+
| medusa-interfaces                  | illformed_requirement |
+------------------------------------+-----------------------+

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Aug 15, 2024
@sachin-sandhu sachin-sandhu marked this pull request as ready for review August 15, 2024 19:07
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner August 15, 2024 19:07
@sachin-sandhu sachin-sandhu merged commit 30bc4f5 into main Aug 15, 2024
122 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/illformed-requirement branch August 15, 2024 19:26
imajes pushed a commit to imajes/dependabot-core that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants