Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handler for Dependabot::Updater::SubprocessFailed: Subprocess issues #10512

Merged
merged 3 commits into from
Aug 29, 2024

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Aug 28, 2024

What are you trying to accomplish?

Preface: Issue related with Dependabot::Updater::SubprocessFailed: Subprocess issues

Issues: Unhandled exceptions in YARN package manager response

Fix: Adds error handlers for following:

Request returned a 403
authentication required
Permission denied
bad_request
500 Internal Server Error
Couldn't find package

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu marked this pull request as ready for review August 28, 2024 22:26
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner August 28, 2024 22:26
Copy link
Contributor

@kbukum1 kbukum1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a comment about adding explanations for the errors. Other than that, it looks great to me. Approved!

@sachin-sandhu sachin-sandhu merged commit 07998eb into main Aug 29, 2024
65 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/npm-error-fixes-subprocesshelper branch August 29, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants