Implement maven version specification

[amazimbe]

What are you trying to accomplish?

Implement the maven version specification described here: https://maven.apache.org/pom.html#Version_Order_Specification.

Our current maven version implementation is not consistent with the maven specification above. In some cases, this causes versions to be compared incorrectly and inconsistently.

Fix issues related to version precedence or malformed version errors.

Checklist

• I have run the complete test suite to ensure all tests and linters pass.
• I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
• I have written clear and descriptive commit messages.
• I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
• I have ensured that the code is well-documented and easy to understand.

[abdulapopoola]

Thanks @amazimbe , as discussed, can you add the test coverage information for before/after?

Also, what's the plan to actually start using this version code instead of the old one?

[amazimbe]

Also, what's the plan to actually start using this version code instead of the old one?

That will come in my next PR. I had a look at it briefly yesterday and some of it is just updating references from Gem::Version to Dependabot::Maven::Version. I also need to define a satified_by?(version) method on requirement.rb plus a few other things.

[amazimbe]

Thanks @amazimbe , as discussed, can you add the test coverage information for before/after?

For the current version.rb
Code coverage: 100%
Branch coverage: 88.57%

For new_version.rb
Code coverage: 100%
Branch coverage: 100%

[abdulapopoola]

Thanks @amazimbe , as discussed, can you add the test coverage information for before/after?

For the current version.rb Code coverage: 100% Branch coverage: 88.57%

For new_version.rb Code coverage: 100% Branch coverage: 100%

what about the original code coverage numbers?

[amazimbe]

In this PR I'm just adding new_version.rb and that's what has 100% code and branch coverage. I didn't change maven's version.rb in this PR so the code coverage stays at 100% and branch coverage at 88.57%.

[abdulapopoola]

Approving pending resolution of comments and @sachin-sandhu 's review

[abdulapopoola]

any reason this is a nilable Integer?

[amazimbe]

This one is mostly because the call on line 43 is nilable. I tried to change this one but sorbet keeps complaining.