Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mount .rubocop_todo.yml to enable successful rubocop execution #10544

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Jefffrey
Copy link
Contributor

@Jefffrey Jefffrey commented Sep 3, 2024

What are you trying to accomplish?

When following README steps:

dependabot-core/README.md

Lines 409 to 415 in dc7b8d2

Style is enforced by [RuboCop](https://rubocop.org/). To check for style violations, simply run `rubocop` in
each of the packages, e.g.
```bash
$ cd go_modules
$ rubocop
```

Facing issue with running rubocop locally:

dependabot-core$ bin/docker-dev-shell cargo
 > image dependabot/dependabot-core-development-cargo already exists

=> running docker development shell
[dependabot-core-dev] ~ $ cd cargo
[dependabot-core-dev] ~/cargo $ rubocop
Configuration file not found: /home/dependabot/.rubocop_todo.yml
[dependabot-core-dev] ~/cargo $

Fix mount to enable local execution of rubocop

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@Jefffrey Jefffrey requested a review from a team as a code owner September 3, 2024 14:06
@jurre jurre merged commit 78fc799 into dependabot:main Sep 3, 2024
35 checks passed
@Jefffrey Jefffrey deleted the fix-rubocop-dev-shell branch September 3, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants