Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix showing bundler v1 deprecation warnings in PR message and logs #10554

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

kbukum1
Copy link
Contributor

@kbukum1 kbukum1 commented Sep 5, 2024

What are you trying to accomplish?

This PR ensures that deprecation warnings for bundler v1 are properly displayed in both the pull request message and the logs.

Anything you want to highlight for special attention from reviewers?

There are two key fixes in this PR:

  1. PR Message Warning: The bundler v1 deprecation warning is now correctly displayed in the PR message without including the "Bumps rails..." message within the warning block.

    Example of the fixed warning:
    Screenshot 2024-09-05 at 10 35 32 AM

  2. Logging Warning Consistency: In the log output, the second deprecation warning message ("Please upgrade to version v2.") should properly work under the updater thread.

Checklist

After fix:
Screenshot 2024-09-05 at 11 08 44 AM

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@kbukum1 kbukum1 marked this pull request as ready for review September 5, 2024 17:25
@kbukum1 kbukum1 requested a review from a team as a code owner September 5, 2024 17:25
@kbukum1 kbukum1 marked this pull request as draft September 5, 2024 17:25
@kbukum1 kbukum1 requested a review from Nishnha September 5, 2024 17:28
@kbukum1 kbukum1 changed the title Fix for showing bundler v1 deprecation warnings in PR message and logs properly Fix showing bundler v1 deprecation warnings in PR message and logs properly Sep 5, 2024
@kbukum1 kbukum1 changed the title Fix showing bundler v1 deprecation warnings in PR message and logs properly Fix showing bundler v1 deprecation warnings in PR message and logs Sep 5, 2024
@kbukum1 kbukum1 marked this pull request as ready for review September 5, 2024 17:43
Copy link
Member

@abdulapopoola abdulapopoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please can you add screenshots of your local run showing the fix too.

@kbukum1
Copy link
Contributor Author

kbukum1 commented Sep 5, 2024

Tested in https://github.com/dsp-testing/dependabot-all-updates-test-grouped-10554-3

PR warning message is showing properly
Screenshot 2024-09-05 at 12 17 18 PM

Log is fixed.
Screenshot 2024-09-05 at 12 17 45 PM

CC: @Nishnha , @abdulapopoola

@kbukum1 kbukum1 merged commit efdfe8e into main Sep 5, 2024
123 checks passed
@kbukum1 kbukum1 deleted the kamil/fix_bundler_v1_deprecation_warning_bugs branch September 5, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants