Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Dependabot::Updater::SubprocessFailed issues #10555

Merged
merged 3 commits into from
Sep 10, 2024

Conversation

sachin-sandhu
Copy link
Contributor

@sachin-sandhu sachin-sandhu commented Sep 5, 2024

What are you trying to accomplish?

Preface: Issues related with Dependabot::Updater::SubprocessFailed

Issues: Unhandled exceptions related Yarn YN0001 error codes, Argument errors and URI errors

Fixes: Captures and adds relevant exception handlers

Anything you want to highlight for special attention from reviewers?

How will you know you've accomplished your goal?

Checklist

  • I have run the complete test suite to ensure all tests and linters pass.
  • I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
  • I have written clear and descriptive commit messages.
  • I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
  • I have ensured that the code is well-documented and easy to understand.

@sachin-sandhu sachin-sandhu self-assigned this Sep 5, 2024
@sachin-sandhu sachin-sandhu changed the title adds exception handlers Fixes Dependabot::Updater::SubprocessFailed issues Sep 6, 2024
@sachin-sandhu sachin-sandhu marked this pull request as ready for review September 6, 2024 14:18
@sachin-sandhu sachin-sandhu requested a review from a team as a code owner September 6, 2024 14:18
@@ -160,6 +160,12 @@ module NpmAndYarn
AUTH_ERROR: /YN0001:*.*Fatal Error: could not read Username for '(?<url>.*)': terminal prompts disabled/
}.freeze, T::Hash[String, Regexp])

YN0001_REQ_NOT_FOUND_CODES = T.let({
NO_FILE_DIR: /ENOENT(.*?)no such file or directory/,
REQUIREMENT_NOT_SATISFIED: /provides (?<dep>.*)(.*?)with version (?<ver>.*), which doesn't satisfy what (?<pkg>.*) requests/, # rubocop:disable Layout/LineLength
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure we should be showing this as an error - it seems like a dependabot feature gap?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abdulapopoola , you are correct, removed ENOENT-no such file or directory . This is related with local workspace created by user.

@sachin-sandhu sachin-sandhu merged commit cc58403 into main Sep 10, 2024
65 checks passed
@sachin-sandhu sachin-sandhu deleted the ssandhu/yarn-errors-fix branch September 10, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants