docker-dev-shell: exclude dry-run files #2958
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't persist the
dry-run/
path across container restarts.This might be a performance regression for some workflows, but avoids the potential for private manifests used in testing (e.g. with
LOCAL_GITHUB_ACCESS_TOKEN
) to stick around on the host system.Note that ecosystems that clone by default (e.g.
go_modules
) do not use thedry-run/
path for clones: they use/tmp
, which is already not persisted.