Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mount bundler/helpers in docker dev container #3234

Merged
merged 1 commit into from
Mar 5, 2021
Merged

chore: mount bundler/helpers in docker dev container #3234

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions bin/docker-dev-shell
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,6 +160,7 @@ docker run --rm -ti \
-v "$(pwd)/bundler/Gemfile:$CODE_DIR/bundler/Gemfile" \
-v "$(pwd)/bundler/dependabot-bundler.gemspec:$CODE_DIR/bundler/dependabot-bundler.gemspec" \
-v "$(pwd)/bundler/lib:$CODE_DIR/bundler/lib" \
-v "$(pwd)/bundler/helpers:$CODE_DIR/bundler/helpers" \
-v "$(pwd)/bundler/spec:$CODE_DIR/bundler/spec" \
-v "$(pwd)/bundler/helpers:/opt/bundler" \
-v "$(pwd)/bundler/helpers:/opt/bundler/helpers" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: is this /opt/bundler/helpers mount actually used? It seems eerily close to the $CODE_DIR/bundler/helpers mount we're adding.

I have no idea, just wondering if this was how this was supposed to work, and could be cruft after this fix to how it actually works. I would not be surprised if both are needed for difference cases (e.g. rspec vs bin/dry-run.rb).

This entire comment is idle curiosity and safe to ignore.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think both are needed for now as rspec loads stuff from the code dir, but might only be needed for native helper specs. We copy native helpers to /opt/bundler and run them from there when running dry-runs/tests.

We might be able to simplify this with the bundler 2 work, planning to move the native helpers specs into the helper folder and run rspec from there.

Expand Down