The PR MessageBuilder requires a github_redirection_service to be specified #3301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thepwagner
approved these changes
Mar 19, 2021
…ion_service is a required argument
brrygrdn
force-pushed
the
brrygrdn/github-redirection-service-is-required
branch
from
de880be
to
43f533e
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on: #3276
The root cause of the Dependabot service starting to create lots of mentions on downstream GitHub repositories was due to a change to how we used the MessageBuilder class. Let's avoid allowing a nil value for the
github_redirection_serviceand promote it to a constant with some explanation for posterity.It is worth noting, this is a breaking API change for anyone using this class directly, it should be called out in the ChangeLog.