Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump-version: re-tag the release notes ref #3356

Merged
merged 2 commits into from
Mar 25, 2021
Merged

bump-version: re-tag the release notes ref #3356

merged 2 commits into from
Mar 25, 2021

Conversation

thepwagner
Copy link
Contributor

Following the discussion in #3354 (comment) , let's prefer tagging the commit from the -release-notes branch instead of tagging the merge commit.

This avoids potential races if the main branch changes outside the release notes PR's context (e.g. another PR is merged).

@thepwagner thepwagner self-assigned this Mar 25, 2021
@thepwagner thepwagner requested a review from a team as a code owner March 25, 2021 16:56
thepwagner
thepwagner commented Mar 25, 2021
View reviewed changes
bin/bump-version.rb Outdated Show resolved Hide resolved
feelepxyz
feelepxyz approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@feelepxyz feelepxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thepwagner thepwagner merged commit d11a5ed into main Mar 25, 2021
@thepwagner thepwagner deleted the thepwagner-patch-1 branch March 25, 2021 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feelepxyz feelepxyz feelepxyz approved these changes

Assignees

@thepwagner thepwagner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thepwagner @feelepxyz